Add support for Tron account change #38536
Draft
+537
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-wallet-standard
EdouardBougon
force-pushed
the
tron-account-change
branch
from
7d41f60 to
8bc3923
Compare
EdouardBougon
force-pushed
the
tron-account-change
branch
from
8bc3923 to
4bc9929
Compare
Collaborator
Builds ready [4bc9929]
UI Startup Metrics (1212 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
EdouardBougon
force-pushed
the
tron-account-change
branch
from
4bc9929 to
fc1d5c0
Compare
Collaborator
Builds ready [fc1d5c0]
UI Startup Metrics (1258 ± 122 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
EdouardBougon
force-pushed
the
tron-account-change
branch
from
fc1d5c0 to
604bdfe
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +90 -6)
|
EdouardBougon
force-pushed
the
tron-account-change
branch
from
604bdfe to
183e682
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const tronScope = | ||
| sessionScopes[MultichainNetworks.TRON] || | ||
| sessionScopes[MultichainNetworks.TRON_DEVNET] || | ||
| sessionScopes[MultichainNetworks.TRON_TESTNET]; |
There was a problem hiding this comment.
Bug: Non-existent enum values for Tron testnet networks
The code references MultichainNetworks.TRON_DEVNET and MultichainNetworks.TRON_TESTNET, but these enum values don't exist in the MultichainNetworks enum. The actual testnet values are TRON_NILE and TRON_SHASTA. This will cause tronScope to be undefined for any Tron testnet sessions, preventing account change notifications from being sent for testnet connections. Other parts of the same codebase correctly use TRON_SHASTA and TRON_NILE.
| } from '@metamask/seedless-onboarding-controller'; | ||
| import { PRODUCT_TYPES } from '@metamask/subscription-controller'; | ||
| import { isSnapId } from '@metamask/snaps-utils'; | ||
| import { address } from '@solana/addresses'; |
There was a problem hiding this comment.
Bug: Unused and misplaced Solana address import
The address function is imported from @solana/addresses but never used in this file. All other occurrences of address in the file are object destructuring from parseCaipAccountId(), not calls to this imported function. This appears to be accidentally committed debug code or a copy-paste error.
| `${this.accountsController.name}:selectedAccountChange`, | ||
| async (account) => { | ||
| if ( | ||
| account.type === TrxAccountType.Eoa && |
There was a problem hiding this comment.
Bug: Tron types used outside conditional compilation guard
The code uses TrxAccountType.Eoa and TrxScope.Mainnet outside any conditional compilation block, but these types are imported within ///: BEGIN:ONLY_INCLUDE_IF(tron) guards (lines 66-69). When the tron feature flag is disabled, these identifiers will be undefined, causing runtime errors when comparing account.type === TrxAccountType.Eoa or calling getAccountsFromSelectedAccountGroup with scopes: [TrxScope.Mainnet]. The new Tron subscription code needs to be wrapped in the same conditional blocks.
Additional Locations (2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds Tron accountChanged notifications alongside Solana, unifies non‑EVM accountChanged emit, and updates UI/tests to recognize Tron Wallet Adapter; bumps related dependencies.
accountsChangednotifications on permission updates, selected account, and selected account group changes (_notifyTronAccountChange, new subscriptions).notifyNonEVMAccountChangedForCurrentAccount(handles Solana and Tron) and invoke on CAIP connection init.TronAccountChangedNotifications) and includes default EVM+Tron networks.selectedAccountGroupChangenotification tests; extend connect page tests for Tron Wallet Adapter; update mocks for Tron scopes/methods and permissions utilities defaults.@metamask/chain-agnostic-permissionto^1.3.0and@metamask/multichain-api-middlewareto^1.2.5(lockfile updated).Written by Cursor Bugbot for commit 183e682. This will update automatically on new commits. Configure here.